Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing(dot): create dot unit tests #2446

Closed
wants to merge 4 commits into from
Closed

testing(dot): create dot unit tests #2446

wants to merge 4 commits into from

Conversation

edwardmack
Copy link
Contributor

@edwardmack edwardmack commented Mar 28, 2022 •
edited
Loading

Changes

  • Create unit tests dot package: build_spec_test.go, config_test.go, import_test.go, node_test.go, service_test.go and utils_test.go
  • Note, this PR is based on work done in PR#2112, which has been recreated here to clarify the files that have been updated.

Tests

go test ./dot/ -v

Issues

Primary Reviewer

@edwardmack edwardmack changed the title squash into one commit testing(dot): create dot unit tests Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #2446 (c145175) into development (8abbd87) will increase coverage by 3.09%.
The diff coverage is 37.26%.

@@               Coverage Diff               @@
##           development    #2446      +/-   ##
===============================================
+ Coverage        58.59%   61.69%   +3.09%     
===============================================
  Files              214      215       +1     
  Lines            28004    28016      +12     
===============================================
+ Hits             16410    17284     +874     
+ Misses            9942     8994     -948     
- Partials          1652     1738      +86
Flag Coverage Δ
unit-tests 61.69% <37.26%> (+3.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/core/service.go 74.93% <0.00%> (ø)
dot/state/service.go 49.55% <0.00%> (-0.68%) ⬇️
dot/telemetry/telemetry.go 0.00% <0.00%> (ø)
lib/babe/babe.go 2.98% <0.00%> (-0.60%) ⬇️
lib/babe/verify.go 91.49% <0.00%> (ø)
lib/services/services.go 81.39% <ø> (ø)
dot/utils.go 12.37% <23.07%> (+12.37%) ⬆️
dot/node.go 56.21% <70.76%> (+56.21%) ⬆️
dot/services.go 75.89% <76.92%> (+75.89%) ⬆️
dot/build_spec.go 80.58% <100.00%> (+80.58%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abbd87...c145175. Read the comment docs.

@edwardmack edwardmack self-assigned this Mar 28, 2022
@edwardmack edwardmack marked this pull request as ready for review March 28, 2022 21:34
@edwardmack edwardmack mentioned this pull request Mar 28, 2022
Merged
@qdm12
Copy link
Contributor

qdm12 commented Mar 29, 2022

Before reviewing, I'd suggest we continue on the older PR #2112 to avoid repeating review work. #2112 has the same history as this branch (2022-03-29 morning).

@edwardmack
Copy link
Contributor Author

Closed, see original PR #2112

@edwardmack edwardmack closed this Mar 29, 2022
@edwardmack edwardmack deleted the ed/create_dot_unit_tests_rebase branch June 21, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot Awaiting requested review from noot

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@qdm12 qdm12 Awaiting requested review from qdm12

Assignees

@edwardmack edwardmack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dot unit tests
2 participants
@edwardmack @qdm12